FailedChanges

Summary

  1. Moved auth code into its own module (commit: 6fe6cfec1d9036b608e5205896da6691d0cfc572) (details)
  2. Fix minor issues in the google auth (commit: 9f77ca081da1e40d0d04016cc33cc8334031441b) (details)
  3. Add support to specify a token list file (commit: 213bcc300b36fbeb3cc2a5466dbec9c06a0cc0ec) (details)
  4. Support ValueErrors for reporting errors in auth during profile create (commit: 1cea00e82018488ae5482944a1726ff23afe58c7) (details)
  5. Add support for the token list authenticator (commit: ee8b94dc3bfe27d1db3f820dbbfe265d2921d2d2) (details)
  6. Set the default auth method to "skip" instead of "google_auth" (commit: b3f2d2a3d0ed4dbd5a05e7ac02b9b829dbcf3ff6) (details)
Commit 6fe6cfec1d9036b608e5205896da6691d0cfc572 by shankari
Moved auth code into its own module
Moved all the auth code into an auth module Restructured the auth
module so that the non-skip modules are loaded only when needed Only
changes were the ones required to get the code to work - in particular
- move all the abort/HTTPError code into a webapp specific module
- throw exceptions from auth modules
- comment out client code in the auth module because it is unused, and
it prevents the auth code from running
TODO:
- move the skip auth code also into its own module (dummy-dev?)
- potentially move the auth settings out of keys.json into an
auth-specific json file
- fix bugs in the google auth module
(commit: 6fe6cfec1d9036b608e5205896da6691d0cfc572)
The file was addedemission/net/auth/auth.py
The file was addedemission/net/auth/google_auth.py
The file was modifiedconf/net/api/webserver.conf (diff)
The file was modifiedemission/net/api/cfc_webapp.py (diff)
Commit 9f77ca081da1e40d0d04016cc33cc8334031441b by shankari
Fix minor issues in the google auth
- If the token is invalid, capture it and return a ValueError which
returns a
reasonable error code
- While falling back to the URL verification, try all possible client
IDs, even
the old android one
(commit: 9f77ca081da1e40d0d04016cc33cc8334031441b)
The file was modifiedemission/net/auth/google_auth.py (diff)
Commit 213bcc300b36fbeb3cc2a5466dbec9c06a0cc0ec by shankari
Add support to specify a token list file
This will be used by the new token list method
(commit: 213bcc300b36fbeb3cc2a5466dbec9c06a0cc0ec)
The file was modifiedconf/net/keys.json (diff)
Commit 1cea00e82018488ae5482944a1726ff23afe58c7 by shankari
Support ValueErrors for reporting errors in auth during profile create
as well
Before this, we only checked for the other calls
(commit: 1cea00e82018488ae5482944a1726ff23afe58c7)
The file was modifiedemission/net/api/cfc_webapp.py (diff)
Commit ee8b94dc3bfe27d1db3f820dbbfe265d2921d2d2 by shankari
Add support for the token list authenticator
This is pretty simple - it has a hardcoded list of tokens, and it
checks the incoming token against the hardcoded list. If there is a
match, it is authenticated, if there is no match, a ValueError is
generated.
I tried just returning None instead of generating a ValueError, but
then it just gets mapped to a user with email = None.
(commit: ee8b94dc3bfe27d1db3f820dbbfe265d2921d2d2)
The file was addedemission/net/auth/token_list.py
The file was modifiedemission/net/auth/auth.py (diff)
Commit b3f2d2a3d0ed4dbd5a05e7ac02b9b829dbcf3ff6 by shankari
Set the default auth method to "skip" instead of "google_auth"
To continue making it easier for devs to work
(commit: b3f2d2a3d0ed4dbd5a05e7ac02b9b829dbcf3ff6)
The file was modifiedconf/net/api/webserver.conf (diff)