SuccessChanges

Summary

  1. Fix another instance of the int64.float -> float conversion (commit: e780ba790ac01a198e576cdc3697500fa4da341c) (details)
  2. Handle the case where the first point of the next section is returned in (commit: dd7a18d24df6f98367d85ecaf23644c4f9f7a2a4) (details)
  3. Add a new script to save ground truth (commit: e039065744fb0e9f77e991d47426bfcb20e67093) (details)
  4. Add an option to turn off the asserts that people can use on production (commit: 4d865e4f3ed435323aafc3117d3dec671a50ef61) (details)
  5. Fix the reading of the config (commit: ceb658c0a764232cfacae30085eb0af423deb404) (details)
  6. Fix regression caused by dropping the last point (commit: a77a3ac6ba5d6b044b9fb712a1dd034818aa70f2) (details)
  7. Spawn processes instead of forking them (commit: 0abc5011d7babdbd04600dc4559d71f58984f6c8) (details)
Commit e780ba790ac01a198e576cdc3697500fa4da341c by shankari
Fix another instance of the int64.float -> float conversion
Similar to d34472fd2eb6bf1e47f1939f2039bd6b2b641d0d,
c302b927ebfd8993d8ffd9e4b72c88912ddf0067
(commit: e780ba790ac01a198e576cdc3697500fa4da341c)
The file was modifiedemission/analysis/intake/cleaning/filter_accuracy.py (diff)
Commit dd7a18d24df6f98367d85ecaf23644c4f9f7a2a4 by shankari
Handle the case where the first point of the next section is returned in
the query
This fixes
https://github.com/e-mission/e-mission-server/issues/530#issuecomment-352206464
Basically, two sections are back to back, then the last point of the
first section will overlap with the first point of the second section.
So a query based on the start and end time for the first section will
return the the first point of the second section as well, which causes a
mismatch between the re-retrieved and stored speeds and distances.
We detect and drop the last point in this case.
(commit: dd7a18d24df6f98367d85ecaf23644c4f9f7a2a4)
The file was addedemission/tests/data/real_examples/another_speed_assertion_failure.jan-16.ground_truth
The file was addedemission/tests/data/real_examples/another_speed_assertion_failure.jan-16
The file was modifiedemission/analysis/intake/cleaning/clean_and_resample.py (diff)
The file was modifiedemission/tests/analysisTests/intakeTests/TestPipelineRealData.py (diff)
Commit e039065744fb0e9f77e991d47426bfcb20e67093 by shankari
Add a new script to save ground truth
easier than copy-pasting commands. Also update the instructions on top
of the file to match reality
(commit: e039065744fb0e9f77e991d47426bfcb20e67093)
The file was addedbin/debug/save_ground_truth.py
The file was modifiedemission/tests/analysisTests/intakeTests/TestPipelineRealData.py (diff)
Commit 4d865e4f3ed435323aafc3117d3dec671a50ef61 by shankari
Add an option to turn off the asserts that people can use on production
(commit: 4d865e4f3ed435323aafc3117d3dec671a50ef61)
The file was addedconf/analysis/debug.conf.json.sample
The file was modifiedemission/analysis/intake/cleaning/clean_and_resample.py (diff)
The file was modifiedemission/analysis/intake/cleaning/clean_and_resample.py (diff)
Commit a77a3ac6ba5d6b044b9fb712a1dd034818aa70f2 by shankari
Fix regression caused by dropping the last point
We started dropping the last point in
ceb658c0a764232cfacae30085eb0af423deb404
This caused a regression because sometimes the last point is from the
current trip, just with speed and distance = 0. Add a new check for the
time delta in addition to speed and distance.
This fixes the regressions
(commit: a77a3ac6ba5d6b044b9fb712a1dd034818aa70f2)
The file was modifiedemission/analysis/intake/cleaning/clean_and_resample.py (diff)
Commit 0abc5011d7babdbd04600dc4559d71f58984f6c8 by shankari
Spawn processes instead of forking them
This fixes
https://github.com/e-mission/e-mission-server/issues/530#issuecomment-352219808
dealing with using pymongo in a multi-process environment
```
/Users/shankari/OSS/anaconda/envs/emission/lib/python3.6/site-packages/pymongo/topology.py:145:
UserWarning: MongoClient opened before fork. Create MongoClient with
connect=False, or create client after forking. See PyMongo's
documentation for details:
http://api.mongodb.org/python/current/faq.html#pymongo-fork-safe>
"MongoClient opened before fork. Create MongoClient "
/Users/shankari/OSS/anaconda/envs/emission/lib/python3.6/site-packages/pymongo/topology.py:145:
UserWarning: MongoClient opened before fork. Create MongoClient with
connect=False, or create client after forking. See PyMongo's
documentation for details:
http://api.mongodb.org/python/current/faq.html#pymongo-fork-safe>
"MongoClient opened before fork. Create MongoClient "
/Users/shankari/OSS/anaconda/envs/emission/lib/python3.6/site-packages/pymongo/topology.py:145:
UserWarning: MongoClient opened before fork. Create MongoClient with
connect=False, or create client after forking. See PyMongo's
documentation for details:
http://api.mongodb.org/python/current/faq.html#pymongo-fork-safe>
"MongoClient opened before fork. Create MongoClient "
```
spawning instead of forking ensures that the subprocesses don't inherit
the MongoClient object from the parent and create new ones instead.
``` storage not configured, falling back to sample, default
configuration Connecting to database URL localhost debug not configured,
falling back to sample, default configuration storage not configured,
falling back to sample, default configuration Connecting to database URL
localhost storage not configured, falling back to sample, default
configuration Connecting to database URL localhost storage not
configured, falling back to sample, default configuration Connecting to
database URL localhost
```
(commit: 0abc5011d7babdbd04600dc4559d71f58984f6c8)
The file was modifiedemission/pipeline/scheduler.py (diff)