SuccessChanges

Summary

  1. Minor fixes to push notifications (commit: fc6250e6bf5e581d0337b27bec876a93d1564737) (details)
  2. Update the sample conf to reflect the new config option (commit: ea326b920a4371a5584edb95308621c9d1ea8f55) (details)
Commit fc6250e6bf5e581d0337b27bec876a93d1564737 by shankari
Minor fixes to push notifications
- Make the package name configurable so that it works with apps other
than
emission. This fixes
https://github.com/e-mission/e-mission-docs/issues/373
- Makes the iOS silent push consistent with the visible push
notifications wrt
return type
Testing done: Generated iOS silent push notifications. Output
``` DEBUG:root:{'ios': {'multicast_ids': [6201858508613677751],
'success': 4, 'failure': 0, 'canonical_ids': 0, 'results':
[{'message_id': '1560234116610162'}, {'message_id': '1560234116609706'},
{'message_id': '1560234116609705'}, {'message_id': '1560234116609608'}],
'topic_message_id': None}, 'android': {'success': 'skipped', 'failure':
'skipped', 'results': 'skipped'}} DEBUG:root:module_name =
emission.net.ext_service.push.notify_interface_impl.firebase
DEBUG:root:module = <module
'emission.net.ext_service.push.notify_interface_impl.firebase' from
'/Users/shankari/e-mission/e-mission-server/emission/net/ext_service/push/notify_interface_impl/firebase.py'>
DEBUG:root:interface_obj_fn = <function get_interface at 0x10ba4ad90>
WARNING:root:No package name specified, defaulting to embase
DEBUG:root:interface_obj =
<emission.net.ext_service.push.notify_interface_impl.firebase.FirebasePush
object at 0x10a328da0> DEBUG:root:interface_obj =
<emission.net.ext_service.push.notify_interface_impl.firebase.FirebasePush
object at 0x10a328da0> DEBUG:root:firebase push result for ios: success
4 failure 0 results [{'message_id': '1560234116610162'}, {'message_id':
'1560234116609706'}, {'message_id': '1560234116609705'}, {'message_id':
'1560234116609608'}] DEBUG:root:firebase push result for android:
success skipped failure skipped results skipped
```
(commit: fc6250e6bf5e581d0337b27bec876a93d1564737)
The file was modifiedemission/net/ext_service/push/notify_interface_impl/firebase.py (diff)
Commit ea326b920a4371a5584edb95308621c9d1ea8f55 by shankari
Update the sample conf to reflect the new config option
To be consistent with
https://github.com/e-mission/e-mission-server/pull/703/commits/fc6250e6bf5e581d0337b27bec876a93d1564737
(commit: ea326b920a4371a5584edb95308621c9d1ea8f55)
The file was modifiedconf/net/ext_service/push.json.sample (diff)