FailedChanges

Summary

  1. [SPARK-25076][SQL] SQLConf should not be retrieved from a stopped (details)
  2. [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and millisToDays (details)
Commit 9bfc55b1b0aae269320bb978027a800fd1878149 by gatorsmile
[SPARK-25076][SQL] SQLConf should not be retrieved from a stopped
SparkSession
## What changes were proposed in this pull request?
When a `SparkSession` is stopped, `SQLConf.get` should use the fallback
conf to avoid weird issues like
``` sbt.ForkMain$ForkError: java.lang.IllegalStateException:
LiveListenerBus is stopped.
at
org.apache.spark.scheduler.LiveListenerBus.addToQueue(LiveListenerBus.scala:97)
at
org.apache.spark.scheduler.LiveListenerBus.addToStatusQueue(LiveListenerBus.scala:80)
at
org.apache.spark.sql.internal.SharedState.<init>(SharedState.scala:93)
at
org.apache.spark.sql.SparkSession$$anonfun$sharedState$1.apply(SparkSession.scala:120)
at
org.apache.spark.sql.SparkSession$$anonfun$sharedState$1.apply(SparkSession.scala:120)
at scala.Option.getOrElse(Option.scala:121)
...
```
## How was this patch tested?
a new test suite
Closes #22056 from cloud-fan/session.
Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Xiao Li
<gatorsmile@gmail.com>
(cherry picked from commit fec67ed7e95483c5ea97a7b263ad4bea7d3d42b5)
Signed-off-by: Xiao Li <gatorsmile@gmail.com>
The file was modifiedsql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala (diff)
The file was modifiedsql/core/src/test/scala/org/apache/spark/sql/LocalSparkSession.scala (diff)
The file was addedsql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfGetterSuite.scala
Commit b426ec583fb5176461c5b0c7112d2194af66d93d by srowen
[SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and millisToDays
fails w/java 8 181-b13
## What changes were proposed in this pull request?
- Update DateTimeUtilsSuite so that when testing roundtripping in
daysToMillis and millisToDays multiple skipdates can be specified.
- Updated test so that both new years eve 2014 and new years day 2015
are skipped for kiribati time zones.  This is necessary as java versions
pre 181-b13 considered new years day 2015 to be skipped while susequent
versions corrected this to new years eve.
## How was this patch tested? Unit tests
Author: Chris Martin <chris@cmartinit.co.uk>
Closes #21901 from d80tb7/SPARK-24950_datetimeUtilsSuite_failures.
(cherry picked from commit c5b8d54c61780af6e9e157e6c855718df972efad)
Signed-off-by: Sean Owen <srowen@gmail.com>
The file was modifiedsql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala (diff)