SuccessChanges

Summary

  1. [MINOR][BUILD] Add ECCN notice required by (details)
  2. [SPARK-25081][CORE] Nested spill in ShuffleExternalSorter should not (details)
  3. [SPARK-24908][R][STYLE] removing spaces to make lintr happy (details)
Commit 7306ac71da0e31fa9655c5838dc7fcb6e4c0b7a0 by srowen
[MINOR][BUILD] Add ECCN notice required by
http://www.apache.org/dev/crypto.html
Add ECCN notice required by http://www.apache.org/dev/crypto.html See
https://issues.apache.org/jira/browse/LEGAL-398
This should probably be backported to 2.3, 2.2, as that's when the key
dep (commons crypto) turned up. BC is actually unused, but still there.
N/A
Closes #22064 from srowen/ECCN.
Authored-by: Sean Owen <srowen@gmail.com> Signed-off-by: Sean Owen
<srowen@gmail.com>
(cherry picked from commit 91cdab51ccb3a4e3b6d76132d00f3da30598735b)
Signed-off-by: Sean Owen <srowen@gmail.com>
The file was modifiedNOTICE (diff)
Commit 04c652064861720d991675b7f5b53f2bbca9d14d by zsxwing
[SPARK-25081][CORE] Nested spill in ShuffleExternalSorter should not
access released memory page
## What changes were proposed in this pull request?
This issue is pretty similar to
[SPARK-21907](https://issues.apache.org/jira/browse/SPARK-21907).
"allocateArray" in
[ShuffleInMemorySorter.reset](https://github.com/apache/spark/blob/9b8521e53e56a53b44c02366a99f8a8ee1307bbf/core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java#L99)
may trigger a spill and cause ShuffleInMemorySorter access the released
`array`. Another task may get the same memory page from the pool. This
will cause two tasks access the same memory page. When a task reads
memory written by another task, many types of failures may happen. Here
are some examples I  have seen:
- JVM crash. (This is easy to reproduce in a unit test as we fill newly
allocated and deallocated memory with 0xa5 and 0x5a bytes which usually
points to an invalid memory address)
- java.lang.IllegalArgumentException: Comparison method violates its
general contract!
- java.lang.NullPointerException at
org.apache.spark.memory.TaskMemoryManager.getPage(TaskMemoryManager.java:384)
- java.lang.UnsupportedOperationException: Cannot grow BufferHolder by
size -536870912 because the size after growing exceeds size limitation
2147483632
This PR resets states in `ShuffleInMemorySorter.reset` before calling
`allocateArray` to fix the issue.
## How was this patch tested?
The new unit test will make JVM crash without the fix.
Closes #22062 from zsxwing/SPARK-25081.
Authored-by: Shixiong Zhu <zsxwing@gmail.com> Signed-off-by: Shixiong
Zhu <zsxwing@gmail.com>
(cherry picked from commit f5aba657396bd4e2e03dd06491a2d169a99592a7)
Signed-off-by: Shixiong Zhu <zsxwing@gmail.com>
The file was modifiedcore/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java (diff)
The file was addedcore/src/test/scala/org/apache/spark/shuffle/sort/ShuffleExternalSorterSuite.scala
Commit a0a7e41cfbcebf1eb0228b4acfdb0381c8eeb79f by srowen
[SPARK-24908][R][STYLE] removing spaces to make lintr happy
## What changes were proposed in this pull request?
during my travails in porting spark builds to run on our centos worker,
i managed to recreate (as best i could) the centos environment on our
new ubuntu-testing machine.
while running my initial builds, lintr was crashing on some extraneous
spaces in test_basic.R (see:
https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.6-ubuntu-test/862/console)
after removing those spaces, the ubuntu build happily passed the lintr
tests.
## How was this patch tested?
i then tested this against a modified spark-master-test-sbt-hadoop-2.6
build (see
https://amplab.cs.berkeley.edu/jenkins/view/RISELab%20Infra/job/testing-spark-master-test-with-updated-R-crap/4/),
which scp'ed a copy of test_basic.R in to the repo after the git clone.
everything seems to be working happily.
Author: shane knapp <incomplete@gmail.com>
Closes #21864 from shaneknapp/fixing-R-lint-spacing.
(cherry picked from commit 3efdf35327be38115b04b08e9c8d0aa282a904ab)
Signed-off-by: Sean Owen <srowen@gmail.com>
The file was modifiedR/pkg/inst/tests/testthat/test_basic.R (diff)