FailedChanges

Summary

  1. [SPARK-25609][TESTS] Reduce time of test for SPARK-22226 (details)
  2. [SPARK-25606][TEST] Reduce DateExpressionsSuite test time costs in (details)
  3. [SPARK-25605][TESTS] Run cast string to timestamp tests for a subset of (details)
  4. [SPARK-25408] Move to mode ideomatic Java8 (details)
  5. Revert "[SPARK-25408] Move to mode ideomatic Java8" (details)
Commit 85a93595d505ff40971f3c797b43e3de6e5a7760 by gatorsmile
[SPARK-25609][TESTS] Reduce time of test for SPARK-22226
## What changes were proposed in this pull request?
The PR changes the test introduced for SPARK-22226, so that we don't run
analysis and optimization on the plan. The scope of the test is code
generation and running the above mentioned operation is expensive and
useless for the test.
The UT was also moved to the `CodeGenerationSuite` which is a better
place given the scope of the test.
## How was this patch tested?
running the UT before SPARK-22226 fails, after it passes. The execution
time is about 50% the original one. On my laptop this means that the
test now runs in about 23 seconds (instead of 50 seconds).
Closes #22629 from mgaido91/SPARK-25609.
Authored-by: Marco Gaido <marcogaido91@gmail.com> Signed-off-by:
gatorsmile <gatorsmile@gmail.com>
The file was modifiedsql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala (diff)
The file was modifiedsql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala (diff)
Commit f27d96b9f35799bf7ecc850effbfdb0bf7b237ab by gatorsmile
[SPARK-25606][TEST] Reduce DateExpressionsSuite test time costs in
Jenkins
## What changes were proposed in this pull request?
Reduce `DateExpressionsSuite.Hour` test time costs in Jenkins by reduce
iteration times.
## How was this patch tested? Manual tests on my local machine. before:
```
- Hour (34 seconds, 54 milliseconds)
``` after:
```
- Hour (2 seconds, 697 milliseconds)
```
Closes #22632 from wangyum/SPARK-25606.
Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: gatorsmile
<gatorsmile@gmail.com>
The file was modifiedsql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala (diff)
Commit 8113b9c96601d8af5b1cbc453630c648a5d45550 by gatorsmile
[SPARK-25605][TESTS] Run cast string to timestamp tests for a subset of
timezones
## What changes were proposed in this pull request?
The test `cast string to timestamp` used to run for all time zones. So
it run for more than 600 times. Running the tests for a significant
subset of time zones is probably good enough and doing this in a
randomized manner enforces anyway that we are going to test all time
zones in different runs.
## How was this patch tested?
the test time reduces to 11 seconds from more than 2 minutes
Closes #22631 from mgaido91/SPARK-25605.
Authored-by: Marco Gaido <marcogaido91@gmail.com> Signed-off-by:
gatorsmile <gatorsmile@gmail.com>
The file was modifiedsql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala (diff)
Commit 44c1e1ab1c26560371831b1593f96f30344c4363 by sean.owen
[SPARK-25408] Move to mode ideomatic Java8
While working on another PR, I noticed that there is quite some legacy
Java in there that can be beautified. For example the use og features
from Java8, such as:
- Collection libraries
- Try-with-resource blocks
No code has been changed
What are your thoughts on this?
This makes code easier to read, and using try-with-resource makes is
less likely to forget to close something.
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration
tests, manual tests)
(If this patch involves UI changes, please attach a screenshot;
otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a
pull request.
Closes #22399 from Fokko/SPARK-25408.
Authored-by: Fokko Driesprong <fokkodriesprong@godatadriven.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
The file was modifiedcore/src/main/java/org/apache/spark/io/ReadAheadInputStream.java (diff)
The file was modifiedcore/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java (diff)
The file was modifiedcommon/network-common/src/test/java/org/apache/spark/network/ChunkFetchIntegrationSuite.java (diff)
The file was modifiedcommon/kvstore/src/main/java/org/apache/spark/util/kvstore/KVStoreSerializer.java (diff)
The file was modifiedcommon/sketch/src/main/java/org/apache/spark/util/sketch/CountMinSketch.java (diff)
The file was modifiedcommon/kvstore/src/test/java/org/apache/spark/util/kvstore/LevelDBSuite.java (diff)
The file was modifiedcore/src/test/java/test/org/apache/spark/JavaAPISuite.java (diff)
The file was modifiedsql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatchSuite.java (diff)
The file was modifiedcommon/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ShuffleIndexInformation.java (diff)
The file was modifiedcore/src/test/java/org/apache/spark/JavaJdbcRDDSuite.java (diff)
The file was modifiedcommon/sketch/src/main/java/org/apache/spark/util/sketch/CountMinSketchImpl.java (diff)
The file was modifiedsql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/CLIService.java (diff)
The file was modifiedcommon/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java (diff)
The file was modifiedsql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/OperationManager.java (diff)
The file was modifiedcore/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java (diff)
The file was modifiedcore/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java (diff)
The file was modifiedcommon/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleSecuritySuite.java (diff)
The file was modifiedcommon/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleIntegrationSuite.java (diff)
The file was modifiedsql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java (diff)
Commit 5ae20cf1a96a33f5de4435fcfb55914d64466525 by wenchen
Revert "[SPARK-25408] Move to mode ideomatic Java8"
This reverts commit 44c1e1ab1c26560371831b1593f96f30344c4363.
The file was modifiedcore/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java (diff)
The file was modifiedcommon/sketch/src/main/java/org/apache/spark/util/sketch/CountMinSketch.java (diff)
The file was modifiedcommon/kvstore/src/test/java/org/apache/spark/util/kvstore/LevelDBSuite.java (diff)
The file was modifiedsql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatchSuite.java (diff)
The file was modifiedcore/src/test/java/org/apache/spark/JavaJdbcRDDSuite.java (diff)
The file was modifiedsql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java (diff)
The file was modifiedcore/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java (diff)
The file was modifiedcore/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java (diff)
The file was modifiedsql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/OperationManager.java (diff)
The file was modifiedcommon/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleSecuritySuite.java (diff)
The file was modifiedcommon/sketch/src/main/java/org/apache/spark/util/sketch/CountMinSketchImpl.java (diff)
The file was modifiedcommon/kvstore/src/main/java/org/apache/spark/util/kvstore/KVStoreSerializer.java (diff)
The file was modifiedsql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/CLIService.java (diff)
The file was modifiedcommon/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ShuffleIndexInformation.java (diff)
The file was modifiedcore/src/main/java/org/apache/spark/io/ReadAheadInputStream.java (diff)
The file was modifiedcore/src/test/java/test/org/apache/spark/JavaAPISuite.java (diff)
The file was modifiedcommon/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleIntegrationSuite.java (diff)
The file was modifiedcommon/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java (diff)
The file was modifiedcommon/network-common/src/test/java/org/apache/spark/network/ChunkFetchIntegrationSuite.java (diff)