SuccessChanges

Summary

  1. [HOT-FIX] Fix compilation errors. (details)
  2. [MINOR] Clean up the joinCriteria in SQL parser (details)
  3. [SPARK-25644][SS][FOLLOWUP][BUILD] Fix Scala 2.12 build error due to (details)
Commit 7ef65c0537ae3ac0961617f427584cc2e3d2a057 by gatorsmile
[HOT-FIX] Fix compilation errors.
The file was modifiedexternal/spark-ganglia-lgpl/src/main/scala/org/apache/spark/metrics/sink/GangliaSink.scala (diff)
Commit 5a617ec4eac26c60facbace15f6f4222b86de6d4 by gatorsmile
[MINOR] Clean up the joinCriteria in SQL parser
## What changes were proposed in this pull request? Clean up the
joinCriteria parsing in the parser by directly using identifierList
## How was this patch tested? N/A
Closes #22648 from gatorsmile/cleanupJoinCriteria.
Authored-by: gatorsmile <gatorsmile@gmail.com> Signed-off-by: gatorsmile
<gatorsmile@gmail.com>
The file was modifiedsql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 (diff)
The file was modifiedsql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala (diff)
Commit 9cbf105ab1256d65f027115ba5505842ce8fffe3 by dongjoon
[SPARK-25644][SS][FOLLOWUP][BUILD] Fix Scala 2.12 build error due to
foreachBatch
## What changes were proposed in this pull request?
This PR fixes the Scala-2.12 build error due to ambiguity in
`foreachBatch` test cases.
-
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-2.7-ubuntu-scala-2.12/428/console
```scala
[error]
/home/jenkins/workspace/spark-master-test-maven-hadoop-2.7-ubuntu-scala-2.12/sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/ForeachBatchSinkSuite.scala:102:
ambiguous reference to overloaded definition,
[error] both method foreachBatch in class DataStreamWriter of type
(function:
org.apache.spark.api.java.function.VoidFunction2[org.apache.spark.sql.Dataset[Int],Long])org.apache.spark.sql.streaming.DataStreamWriter[Int]
[error] and  method foreachBatch in class DataStreamWriter of type
(function: (org.apache.spark.sql.Dataset[Int], Long) =>
Unit)org.apache.spark.sql.streaming.DataStreamWriter[Int]
[error] match argument types ((org.apache.spark.sql.Dataset[Int], Any)
=> Unit)
[error]       ds.writeStream.foreachBatch((_, _) =>
{}).trigger(Trigger.Continuous("1 second")).start()
[error]                      ^
[error]
/home/jenkins/workspace/spark-master-test-maven-hadoop-2.7-ubuntu-scala-2.12/sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/ForeachBatchSinkSuite.scala:106:
ambiguous reference to overloaded definition,
[error] both method foreachBatch in class DataStreamWriter of type
(function:
org.apache.spark.api.java.function.VoidFunction2[org.apache.spark.sql.Dataset[Int],Long])org.apache.spark.sql.streaming.DataStreamWriter[Int]
[error] and  method foreachBatch in class DataStreamWriter of type
(function: (org.apache.spark.sql.Dataset[Int], Long) =>
Unit)org.apache.spark.sql.streaming.DataStreamWriter[Int]
[error] match argument types ((org.apache.spark.sql.Dataset[Int], Any)
=> Unit)
[error]       ds.writeStream.foreachBatch((_, _) =>
{}).partitionBy("value").start()
[error]                      ^
```
## How was this patch tested?
Manual.
Since this failure occurs in Scala-2.12 profile and test cases, Jenkins
will not test this. We need to build with Scala-2.12 and run the tests.
Closes #22649 from dongjoon-hyun/SPARK-SCALA212.
Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon
Hyun <dongjoon@apache.org>
The file was modifiedexternal/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala (diff)
The file was modifiedsql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/ForeachBatchSinkSuite.scala (diff)