FailedChanges

Summary

  1. [SPARK-25735][CORE][MINOR] Improve start-thriftserver.sh: print clean (details)
Commit 24f5bbd770033dacdea62555488bfffb61665279 by sean.owen
[SPARK-25735][CORE][MINOR] Improve start-thriftserver.sh: print clean
usage and exit with code 1
## What changes were proposed in this pull request? Currently if we run
``` sh start-thriftserver.sh -h
```
we get
```
... Thrift server options: 2018-10-15 21:45:39 INFO HiveThriftServer2:54
- Starting SparkContext 2018-10-15 21:45:40 INFO SparkContext:54 -
Running Spark version 2.3.2 2018-10-15 21:45:40 WARN NativeCodeLoader:62
- Unable to load native-hadoop library for your platform... using
builtin-java classes where applicable 2018-10-15 21:45:40 ERROR
SparkContext:91 - Error initializing SparkContext.
org.apache.spark.SparkException: A master URL must be set in your
configuration at
org.apache.spark.SparkContext.<init>(SparkContext.scala:367) at
org.apache.spark.SparkContext$.getOrCreate(SparkContext.scala:2493) at
org.apache.spark.sql.SparkSession$Builder$$anonfun$7.apply(SparkSession.scala:934)
at
org.apache.spark.sql.SparkSession$Builder$$anonfun$7.apply(SparkSession.scala:925)
at scala.Option.getOrElse(Option.scala:121) at
org.apache.spark.sql.SparkSession$Builder.getOrCreate(SparkSession.scala:925)
at
org.apache.spark.sql.hive.thriftserver.SparkSQLEnv$.init(SparkSQLEnv.scala:48)
at
org.apache.spark.sql.hive.thriftserver.HiveThriftServer2$.main(HiveThriftServer2.scala:79)
at
org.apache.spark.sql.hive.thriftserver.HiveThriftServer2.main(HiveThriftServer2.scala)
2018-10-15 21:45:40 ERROR Utils:91 - Uncaught exception in thread main
```
After fix, the usage output is clean:
```
... Thrift server options:
--hiveconf <property=value> Use value for given property
```
Also exit with code 1, to follow other scripts(this is the behavior of
parsing option `-h` for other linux commands as well).
## How was this patch tested?
Manual test.
Closes #22727 from gengliangwang/stsUsage.
Authored-by: Gengliang Wang <gengliang.wang@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
The file was modifiedsbin/start-thriftserver.sh (diff)
The file was modifiedsql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala (diff)